Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus trapping to mdl-temporary-drawer #4950

Closed
sgomes opened this issue Dec 1, 2016 · 2 comments
Closed

Add focus trapping to mdl-temporary-drawer #4950

sgomes opened this issue Dec 1, 2016 · 2 comments
Assignees
@sgomes
Labels
in-tracker
Milestone
V2 Beta

Comments

@sgomes
Copy link
Contributor

sgomes commented Dec 1, 2016

It seems we forgot to do focus trapping while the drawer is open, as we do for mdl-simple-menu. We should refactor out the focus trapping code and use it across both components.

@traviskaufman FYI.
@sgomes sgomes added this to the V2 Beta milestone Dec 1, 2016
@sgomes sgomes self-assigned this Dec 1, 2016
@sgomes sgomes mentioned this issue Dec 1, 2016
Closed
@traviskaufman
Copy link
Contributor

Agreed. I think we had talked at one point about holding off on this until we had a general focusing strategy. However since we've had to do the work with simple menu I agree it's worth refactoring out and using across components.

@traviskaufman traviskaufman mentioned this issue Dec 5, 2016
Closed
@sfdexter
Copy link
Collaborator

Superceded by material-components/material-components-web#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgomes sgomes

Labels
in-tracker
Projects
None yet
Milestone
V2 Beta
Development

No branches or pull requests
3 participants
@sgomes @traviskaufman @sfdexter