Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test coverage #58

Open
2 of 3 tasks
evykassirer opened this issue Dec 24, 2016 · 6 comments
Open
2 of 3 tasks

Missing test coverage #58

evykassirer opened this issue Dec 24, 2016 · 6 comments
Labels

Comments

@evykassirer
Copy link
Contributor

evykassirer commented Dec 24, 2016

A great first PR is to pick something on this list and write tests for it!

  • Symbols.js
  • solveEquation/EquationOperations.js
  • in CombineChecks.test.js separately test the functions CombineChecks.canMultiplyLikeTermPolynomialNodes, CombineChecks.canAddLikeTermPolynomialNodes, and CombineChecks.canRearrangeCoefficient

feel free to point out more missing tests below!

@nkprince007
Copy link

Can I be assigned this?

@evykassirer
Copy link
Contributor Author

Yes! Sadly I can't actually assign people to issues on GitHub, but consider it yours!

Thank you 😸

@nkprince007
Copy link

Ok.

@evykassirer
Copy link
Contributor Author

evykassirer commented Jan 25, 2017

FYI @nkprince007, @arbylee wrote tests for Symbols.js in #88 :) so you can just work on the rest of 'em

let me know if you have any questions!

@nkprince007
Copy link

Thanks a lot, guys, but I'm a little caught up ATM, definitely like to contribute, soon as I find time.

@evykassirer
Copy link
Contributor Author

Sounds good @nkprince007! If you don't think you can get to this issue for a few weeks and don't have strong feeling towards it, we can un-assign you and when you have more time you take on whatever's free. If you're exciting about this issue though, we can keep it until you have the time :) let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants