-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use typed javascript in mathsteps #87
Comments
I love types and flow is a great tool, so I think it's a good idea. Longer-term goal makes sense. |
You might also want to consider Typescript here. I have used both and they each have pros and cons but it seems Typescript would be more appropriate for this project. It has better editor integration and it is much more widespread, making it easier for new contributors to get started. |
I'm cool with either. |
edited the issue to reflect what we're talking about better yeah @hmaurer that makes sense. I'm not super familiar with either, but if they both do a good job and typescript is more common that sounds like a good reason to use it :) |
@evykassirer I think we can close this for now; it's probably not something that will be implemented in the near future (following month or so) and it might be clearer if open issues actually correlate to things being worked on. Maybe we could have a list on the wiki of "long term goals" and open issues for them once we actually start work on one of them? |
I think it's worth keeping open and tagging with 'long term goals' as it is right now, so that there can be discussion on it (like what you posted yesterday!) If people want to find things to work on, I hope they can filter out things with the long term label on them. Does that seem reasonable? Thanks for looking through these and helping clean things up :) I'm also a fan of checking things off and having fewer things on my todo list and having things clean! |
Should I try Flow ? and see how it goes ? |
I think we were considering TypeScript instead. We should probably make an educated decision before going forward with one. If you can implement typed javascript in some files but not others, you could try it out for a file or two to see what it would look like :) |
We should probably hold off until #144 lands. Sorry for dragging my feet with that. Definitely encourage experimentation though. :) |
This may help https://github.com/Microsoft/TypeScript-Handbook |
Hi all, |
thanks to @elu00 for this great progress: |
What I gather through a little bit of research: Background (hehe idk):
Porting:
What it does and general notes:TS:
Flow
Notes:
Both have this:
Pro Flow:
Against Flow:
|
Bad error messaging is due to poorly configured
In the above example I've included the dependency |
One more thing, as @kevinbarabash is working on the new parser, I was thinking that it may help (me or someone else) to include the support for Flow in mathsteps. So If a developer is using mathsteps directly or we expose the api for the new parser in future, we should definitely include support for both Flow and Typescript. ? |
The parser I'm working will have a different AST structure. As part of that work I'm adding a rule rewriting system. This will allows changes to be defined as strings of math with placeholders, e.g.
You can follow that work at semantic-math/math-parser#27. I think that having a system like this will simplify the existing search/transform functions substantially, but it will mean lots of changes to those files. If people are interested in adopting a system like this, then I think it's probably best to start using Flow/Typescript in files outside of search. |
opinion from Kevin on gitter:
|
it seems like it would be a good idea to wait for Kevin to make more progress until we start implementing typed javascript (adding blocked to the tags) - though we can keep talking about it, and if someone thinks there'd be benefit in adding it now I'm definitely open to talk about it there are some other issues open for bugs and functionality that seem like a better place to put focus on for now (and I'll be adding a bunch more in the next few days!) |
options:
curious what you think @aelnaiem
The text was updated successfully, but these errors were encountered: