New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP messages: only iBGP should include a LocalPref #266

Closed
vaizki opened this Issue Jun 21, 2018 · 0 comments

Comments

Projects
2 participants
@vaizki
Copy link

vaizki commented Jun 21, 2018

Andrey on Kubernetes Slack reported:

Hi again, just checked juniper logs regarding bgp sessions with metallb speakers and found something unexpected: speakers are sending localpref attribute to eBGP peers
BGP_ERROR_UNEXPECTED_LOCAL_PREF: bgp_recv_v4_update: external peer x.x.x.x (External AS 65400) UPDATE included LOCALPREF attribute

Indeed, only iBGP sessions inside the same AS can contain a localpref but right now it is included in all advertisements.

b.Write([]byte{

Probably doesn't break anything but may flood some logs.

@danderson danderson self-assigned this Jun 27, 2018

@danderson danderson added the bug label Jun 27, 2018

@danderson danderson added this to To Do in BGP mode via automation Jun 27, 2018

danderson added a commit to danderson/metallb that referenced this issue Jun 27, 2018

BGP mode automation moved this from To Do to Done Jun 27, 2018

danderson added a commit that referenced this issue Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment