Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about feature log #324

Closed
18liumin opened this issue Dec 8, 2023 · 1 comment
Closed

questions about feature log #324

18liumin opened this issue Dec 8, 2023 · 1 comment

Comments

@18liumin
Copy link

18liumin commented Dec 8, 2023

result = log_reader.read_log_as_sequence_examples(log_path)
if len(result) != 1:
return {}

Why does this code need to determine the “if len(result) != 1”?

@mtrofin
Copy link
Collaborator

mtrofin commented Dec 8, 2023

I'm going to assume this is here. Inlining is treated as a module-wide problem, as opposed to for example regalloc which is per-function. So for the whole problem, we expect to get at most 1 trace. We may get 0 traces for corner-case modules that trigger no inlining decisions - like a module with 1 function, or functions that have no call sites, or callsites to functions defined in other modules, exclusively.

@mtrofin mtrofin closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants