Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnippetClient does not explicitly handle self._proc in USB disconnect case. #509

Closed
xpconanfan opened this issue Sep 28, 2018 · 1 comment
Assignees

Comments

@xpconanfan
Copy link
Collaborator

xpconanfan commented Sep 28, 2018

When the USB disconnects (without rebooting the device), self._proc essentially becomes useless.
Right now the behavior is implicitly assumed.
We should handle this better.

Discovered when doing #507

@mhaoli
Copy link
Collaborator

mhaoli commented Jul 14, 2022

Currently, the client will set it to None when restoring the connection to the server. I think this is enough.

On the one hand, the client will no longer use self._proc. On the other hand, setting it to None will clean up the zombie processes in the system. So I think this is enough.

@mhaoli mhaoli closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants