Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Ruby client to rubygems #5

Closed
sffc opened this issue Mar 12, 2018 · 5 comments
Closed

Publish Ruby client to rubygems #5

sffc opened this issue Mar 12, 2018 · 5 comments

Comments

@sffc
Copy link
Collaborator

sffc commented Mar 12, 2018

#3 added a Ruby client to myanmar-tools. It would be great to see it published to rubygems for easy installation.

It is okay for either @kirankarki or someone from Google to publish the gem, as long as a Google-owned account has access to push updates.

@kirankarki
Copy link
Contributor

kirankarki commented Mar 13, 2018

Hi @sffc,

Thank you for this fix 1de7e70 and merging the pull request.

I will publish the gem to rubygems, and also modify the usage guide and add demo of this client.

@kirankarki
Copy link
Contributor

Hi @sffc,

I have published the gem to rubygems host.
And also modified the usage guide and added demo of this client under samples/ruby.

I have created a pull request for the above changes.

@sffc
Copy link
Collaborator Author

sffc commented Mar 20, 2018

Thank you!

Can you please give the following two accounts access to edit the gem on rubygems.org?

  • "google-myanmar-tools-user" --> this is a Google-owned account so that we are able to push updates in the future
  • "sffc" --> this is my account

I made a few changes to the documentation. The ICU converter is available in Ruby, so I put that in the example code and updated the README accordingly.

49fb350...master

I'm also a fan of bundle add as an alternative to gem install. 🙂

@kirankarki
Copy link
Contributor

Hi @sffc,

Thank you for the amendments.

I have added the above two accounts to gem owners list.

https://rubygems.org/gems/myanmar-tools

@sffc
Copy link
Collaborator Author

sffc commented Apr 14, 2018

Looks good, and thanks again for the contribution!

@sffc sffc closed this as completed Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants