Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

Authenticate client connections with mysql_native_password #7

Merged
merged 1 commit into from Mar 18, 2019

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Feb 10, 2019

Issue: #6

Example use:

$ ./my sql -BNe "SELECT PASSWORD('foobar')"
*9B500343BC52E2911172EB52AE5CF4847604C6E5
$ rippled -ripple_server_password_hash=9B500343BC52E2911172EB52AE5CF4847604C6E5

mysql_protocol.cc Outdated Show resolved Hide resolved
mysql_protocol.cc Outdated Show resolved Hide resolved
mysql_protocol.cc Outdated Show resolved Hide resolved
mysql_protocol.cc Outdated Show resolved Hide resolved
mysql_protocol.cc Show resolved Hide resolved
mysql_protocol.cc Show resolved Hide resolved
mysql_protocol.cc Show resolved Hide resolved
@pivanof
Copy link
Contributor

pivanof commented Mar 2, 2019

@dveeden I see there were a couple force pushes here (that I wasn't notified about), but no comments from you. Are you still working on this PR or is it ready for the next round of review?

@dveeden
Copy link
Contributor Author

dveeden commented Mar 3, 2019

Hi @pivanof

I assumed that github would notify you about resolved issues. I'll put a note in the PR next time this happens.

This PR is ready for another round of review.
Note that #9 has the commit from this PR and another commit on top of that to add compatibility with MySQL 8.0, that PR is also ready for review.

So let's first do this PR and then #9

Copy link
Contributor

@pivanof pivanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, now I see that you even marked my comments as resolved. It's really strange that github didn't send any notification to me about that. I guess it's better to add some comments about resolution rather than just click "Resolve"...

And since I guess you will send more PRs in the future I want to ask you one thing: can you please do modifications as separate commits instead of amending the initial commit? This will make it easier to see what exactly has changed compared to the last time I looked at the PR (and this will actually also make github send notification that a new commit was uploaded). In the end I will squash and merge it as a single commit anyway.

mysql_protocol.cc Outdated Show resolved Hide resolved
mysql_protocol.cc Show resolved Hide resolved
@dveeden
Copy link
Contributor Author

dveeden commented Mar 17, 2019

I've pushed a new version.

@pivanof pivanof merged commit 0b6c9f4 into google:master Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants