Authenticate client connections with mysql_native_password #7
Conversation
eecbc29
to
e87434a
Compare
fd664e3
to
35ab4b7
Compare
@dveeden I see there were a couple force pushes here (that I wasn't notified about), but no comments from you. Are you still working on this PR or is it ready for the next round of review? |
Hi @pivanof I assumed that github would notify you about resolved issues. I'll put a note in the PR next time this happens. This PR is ready for another round of review. So let's first do this PR and then #9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I see that you even marked my comments as resolved. It's really strange that github didn't send any notification to me about that. I guess it's better to add some comments about resolution rather than just click "Resolve"...
And since I guess you will send more PRs in the future I want to ask you one thing: can you please do modifications as separate commits instead of amending the initial commit? This will make it easier to see what exactly has changed compared to the last time I looked at the PR (and this will actually also make github send notification that a new commit was uploaded). In the end I will squash and merge it as a single commit anyway.
35ab4b7
to
54eeb11
Compare
I've pushed a new version. |
mysql_native_password
by default. See also: Support for AuthSwitchRequest to better support MySQL 8.0 clients vitessio/vitess#4332 and https://bugs.mysql.com/bug.php?id=93044 . This affects MySQL 8.0 clients as 8.0 always tries to authenticate withcaching_sha2_password
. The solution is to implementcaching_sha2_password
over TLS and/or implementAuthSwitchRequest
.Issue: #6
Example use: