New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential bug in the Microfacet BRDF model #18

Closed

leehsiu opened this issue Oct 28, 2021 · 1 comment

leehsiu commented Oct 28, 2021

nerfactor/brdf/microfacet/microfacet.py

Line 57 in 0831990

g = self._get_g(pts2c, h, normal, alpha=alpha) # NxL

The shadow term is calculated as g = self._get_g(pts2c, h, normal, alpha=alpha) # NxL

However, according two Equ.(23) in the original BTDF paper it should be G(v,m)G(l,m).

Here only half part is calculated.

Collaborator

xiumingzhang commented May 17, 2022

Which "Equ.(23)"?

xiumingzhang closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment