Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

go get is broken since cdd605f5e2f5158c8d3f8f752cba0a53b0aac4ec #18

Closed
tamird opened this issue Feb 28, 2019 · 1 comment
Closed

go get is broken since cdd605f5e2f5158c8d3f8f752cba0a53b0aac4ec #18

tamird opened this issue Feb 28, 2019 · 1 comment

Comments

@tamird
Copy link
Contributor

tamird commented Feb 28, 2019

$ go get -u github.com/google/netstack/...
# github.com/google/netstack/tcpip/transport/ping
../go/src/github.com/google/netstack/tcpip/transport/ping/ping_packet_list.go:16:48: undefined: pingPacket
../go/src/github.com/google/netstack/tcpip/transport/ping/ping_packet_list.go:30:8: undefined: pingPacket
../go/src/github.com/google/netstack/tcpip/transport/ping/ping_packet_list.go:31:8: undefined: pingPacket
# github.com/google/netstack/tcpip/transport/icmp
../go/src/github.com/google/netstack/tcpip/transport/icmp/endpoint.go:31:2: undefined: icmpPacketEntry

This was broken in cdd605f (google/gvisor@b75aa51) which changed the names of generated files and the type definitions they contain.

@kevinGC @iangudger @amscanne

@tamird
Copy link
Contributor Author

tamird commented Feb 28, 2019

Fixed since 6369163.

@tamird tamird closed this as completed Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant