Init process created even when clone_newpid is false

[joelweinberger]

Currently, when an init process is created in pidInitNs, it does this whenever the mode is execve, even when clone_newpid is false. This is problematic since, in that case, the new process will actually now be a child of the execve'd process, and when that process dies, the "init" process is reparented to 1, and becomes a dangling process that never exits.

I believe the line at

nsjail/pid.c

Line 36 in 152d6d6

if (nsjconf->mode != MODE_STANDALONE_EXECVE) {

should be modified to read:
if (nsjconf->mode != MODE_STANDALONE_EXECVE || !nsjconf->clone_newpid) {

That way, an init process would not be created if the mode is execve but clone_newpid is false.

[robertswiecki]

Thanks,

Code added in 6dc0808