Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sgauth.Settings to accept credentials.Credentials #87

Closed
ahmetb opened this issue Dec 25, 2019 · 1 comment
Closed

sgauth.Settings to accept credentials.Credentials #87

ahmetb opened this issue Dec 25, 2019 · 1 comment

Comments

@ahmetb
Copy link

ahmetb commented Dec 25, 2019

I'm trying to understand if oauth2l is primarily supposed to be exec'd out to, to get credentials –or it's supposed to be imported as a Go package (given, I'm using Go).

In that case, I think it would be better to allow sgauth.Settings.CredentialsJSON object to be replaced with a *credentials.Credentials field, as I might be hardcoding the client_id, client_secret etc in my program, or reading from env, etc. I'm assuming the schema of the creds JSON file isn't used to determine the auth format?

I'm trying to implement a tool to do 3LO and it does not seem like there's a clear API surface provided by this repo. I'm assuming this tool is supposed to be exec'd into so maybe I'm doing this wrong.

@ahmetb
Copy link
Author

ahmetb commented Dec 25, 2019

I think I'm supposed to use x/oauth2 + x/oauth2/google myself directly.

@ahmetb ahmetb closed this as completed Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant