Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Fix miniumum JDK version in README.md #122

Closed
yosske opened this issue Jan 29, 2018 · 1 comment
Closed

Fix miniumum JDK version in README.md #122

yosske opened this issue Jan 29, 2018 · 1 comment

Comments

@yosske
Copy link

yosske commented Jan 29, 2018

The "Building Notes" in the README.md file says the minumum JDK for building is:

"JDK 7"

Instead Of:

"JDK 8"

JDK 8 is needed ever since this fix was done:
https://github.com/google/openrtb/blob/master/CHANGELOG.md#version-097-29-10-2015

Thanks :)

@yosske yosske changed the title Fix miniumum JDK in Readme Fix miniumum JDK in README.md Jan 29, 2018
@yosske yosske changed the title Fix miniumum JDK in README.md Fix miniumum JDK version in README.md Jan 29, 2018
@opinali
Copy link
Contributor

opinali commented Jan 30, 2018

Thanks for the heads up, fixed the readme to mention correct versions for JDK and also protoc. :)

@opinali opinali closed this as completed Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants