[CMAKE] When using system Protobuf, protobuf::protoc is not defined.

[yurivict]

protobuf::protoc gets into makefiles:

ortools/sat/boolean_problem.pb.cc: protobuf::protoc

Version: 7.7
OS: FreeBSD 11.2

[Mizux]

Hi,
From where does google or-tools come from ? which branch if git clone ?
Which build system did you use ?
Which command did you run ?
Do you have a log to share ?

[yurivict]

I use the FreeBSD ports framework. cmake/ninja combination fails (cmake/gmake combination also fails).

For configuration cmake is run like this:

UNIX_CBC_DIR=/usr/local UNIX_CLP_DIR=/usr/local PKG_CONFIG=pkgconf XDG_DATA_HOME=/usr/ports/math/or-tools/work  XDG_CONFIG_HOME=/usr/ports/math/or-tools/work  HOME=/usr/ports/math/or-tools/work PATH=/usr/ports/math/or-tools/work/.bin:/home/yuri/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin SHELL=/bin/sh CONFIG_SHELL=/bin/sh \
cmake \
-DCMAKE_C_COMPILER:STRING="cc"  -DCMAKE_CXX_COMPILER:STRING="c++"  -DCMAKE_C_FLAGS:STRING="-O2 -pipe -fno-omit-frame-pointer  -fstack-protector-strong -fno-strict-aliasing "  -DCMAKE_C_FLAGS_DEBUG:STRING="-O2 -pipe -fno-omit-frame-pointer  -fstack-protector-strong -fno-strict-aliasing "  -DCMAKE_C_FLAGS_RELEASE:STRING="-O2 -pipe -fno-omit-frame-pointer  -fstack-protector-strong -fno-strict-aliasing "  -DCMAKE_CXX_FLAGS:STRING="-O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -fno-strict-aliasing -fno-omit-frame-pointer  "  -DCMAKE_CXX_FLAGS_DEBUG:STRING="-O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -fno-strict-aliasing -fno-omit-frame-pointer  "  -DCMAKE_CXX_FLAGS_RELEASE:STRING="-O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -fno-strict-aliasing -fno-omit-frame-pointer  "  -DCMAKE_EXE_LINKER_FLAGS:STRING=" -L/usr/local/lib -fstack-protector-strong "  -DCMAKE_MODULE_LINKER_FLAGS:STRING=" -L/usr/local/lib -fstack-protector-strong "  -DCMAKE_SHARED_LINKER_FLAGS:STRING=" -L/usr/local/lib -fstack-protector-strong "  -DCMAKE_INSTALL_PREFIX:PATH="/usr/local"  -DCMAKE_BUILD_TYPE:STRING="Release"  -DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES  -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=YES  -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DBUILD_DEPS:BOOL=OFF -DINSTALL_BUILD_DEPS:BOOL=OFF -DBUILD_PYTHON:BOOL=OFF -DBUILD_EXAMPLES:BOOL=OFF -GNinja

Failure log: https://people.freebsd.org/~yuri/or-tools-protobuf%3A%3Aprotoc-failure.log

I had to apply this patch:

@${REINPLACE_CMD} -e 's|protobuf::protoc|protoc -I${LOCALBASE}/include| ; s|protobuf$$:$$:protoc||' ${BUILD_WRKSRC}/build.ninja

to work around this issue, because cmake doesn't expand protobuf::protoc.

[Mizux]

ok so you are using the freebsd protobuf package.

You should try to fix https://github.com/google/or-tools/blob/stable/cmake/FindProtobuf.cmake instead which is currently more in its infancy (i.e. it's a skeleton) as you can see.
In the near future I hope to support system dependencies and ease the integration to any distro but it's currently out of the officially supported current scope.

note: concerning freeBSD hope to have soon a vagrant freebsd12 box to test the CMake build (ed using -DBUILD_DEPS=ON)
as first step. (see #2105 )

[Mizux]

seems fixed on master by:
92fd9c5