Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore parsing does not respect repository boundaries #209

Open
michaelkedar opened this issue Feb 14, 2023 · 3 comments
Open

Gitignore parsing does not respect repository boundaries #209

michaelkedar opened this issue Feb 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@michaelkedar
Copy link
Member

The current Gitignore parsing does not take into account the boundaries of git repositories, meaning:

  • .gitignore files that are outside of git repositories are parsed and applied.
  • .gitignore files from the parent repository are applied to files in git subrepositories.
@michaelkedar michaelkedar added the bug Something isn't working label Feb 14, 2023
@hayleycd
Copy link
Collaborator

I see that there have been a couple of PRs associated with this issue. Has the issue been resolved? Or is there still work to be done to address this in its entirety?

There is a section of docs that should be updated if this is complete.

@michaelkedar
Copy link
Member Author

This iteration of this bug hasn't been fixed. There was a previous issue related to this, but that's since been closed.

I don't believe anything has changed since that section of the docs were written, so probably no updates are needed.

@hayleycd
Copy link
Collaborator

@michaelkedar Thanks! I was trying to figure out if it was fully resolved by yesterday's release, but it sounds like it wasn't. I'll wait on the doc update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants