Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide async and sync dart version into two separate packages #66

Closed
goderbauer opened this issue Feb 4, 2016 · 4 comments
Closed

Divide async and sync dart version into two separate packages #66

goderbauer opened this issue Feb 4, 2016 · 4 comments

Comments

@goderbauer
Copy link
Member

I would like to separate the dart version of pageloader into two separate pub packages: One for sync and the other for the async version (similar to how async and sync webdriver.dart is separate).

Advantages:

  • cleaner dependencies (async pageloader doesn't need to depend on sync webdriver)
  • easier to deprecate sync pageloader when it is a separate package
  • versions for async and sync can increase independently

I would suggest keeping both versions in this github repository. I would just change the directory structure from dart/lib/async and dart/lib/sync to dart/async/lib and dart/sync/lib. The same change would be applied to the other directories (test, etc).

@DrMarcII Any objections?

@srawlins
Copy link
Collaborator

srawlins commented Feb 4, 2016

+1; you can then have a dart/async/pubspec.yaml and a dart/sync/pubspec.yaml.

@goderbauer
Copy link
Member Author

@srawlins That is the idea. There will then be two packages on pub.dartlang.org: pageloader and sync_pageloader. This is similar to how we have webdriver and sync_webdriver as packages.

@BlackHC
Copy link
Contributor

BlackHC commented Feb 5, 2016

Great idea! This will make deprecation easier and untangle dependencies.

@goderbauer
Copy link
Member Author

PR implementing this proposal has been merged. Thanks everybody for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants