Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

Consider updating the pinned version of pedantic in the docs (or unpinning) #11

Closed
pq opened this issue Nov 24, 2018 · 2 comments
Closed

Comments

@pq
Copy link
Contributor

pq commented Nov 24, 2018

The instructions in https://github.com/dart-lang/pedantic#enabled-lints suggest this dependency snippet:

dependencies:
  pedantic: '1.1.0'

Should this be updated to 1.4.0? What about unpinning and changing it to ^1.0.0?

/cc @davidmorgan

@a14n
Copy link
Contributor

a14n commented Nov 26, 2018

What about unpinning and changing it to ^1.0.0?

As analysis_options.yaml is included in package every lint that is added might lead to breaking the build. That's why I initially pin the dependency.

BTW one could argument that adding a lint in this file is a breaking change and the version should change accordingly (bump from1.0.0 to 2.0.0).

@davidmorgan
Copy link
Contributor

Let's just keep the example updated for now. Thanks!

@pq pq closed this as completed Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants