Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow open redirect by "target" parameter of /reveal #44

Closed
gimite opened this issue May 14, 2015 · 1 comment
Closed

Do not allow open redirect by "target" parameter of /reveal #44

gimite opened this issue May 14, 2015 · 1 comment
Assignees
@gimite
Labels
bug

Comments

@gimite
Copy link
Contributor

gimite commented May 14, 2015

We should validate that it is in the same domain.
@gimite gimite added the bug label May 14, 2015
@zestyping zestyping mentioned this issue May 14, 2015
Merged
@gimite
Copy link
Contributor Author

gimite commented May 27, 2015

#45 was submitted, but we also need a check that "target" parameter doesn't contain a host name at line 104? Otherwise malicious user can still put a full URL to the "target" param.

@gimite gimite mentioned this issue Jun 11, 2015
Merged
@gimite gimite self-assigned this Jun 11, 2015
@gimite gimite closed this as completed Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gimite gimite

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gimite