Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having trouble building on macOS High Sierra (10.13.3) #37

Closed
malchata opened this issue Feb 5, 2018 · 3 comments
Closed

Having trouble building on macOS High Sierra (10.13.3) #37

malchata opened this issue Feb 5, 2018 · 3 comments

Comments

@malchata
Copy link

malchata commented Feb 5, 2018

When I attempt to compile using make -j8 in macOS High Sierra, I receive the following error:

image_io.cc:1031:31: error: assigning to 'boolean' from incompatible type 'bool'
  cinfo.do_fancy_upsampling = true;
                              ^~~~

Full compiler output: compiler_output.log

Is there anything I'm doing wrong, or is this a legitimate error? Here's my system info (using a Kaby Lake Intel, currently):

Hardware Overview:
Model Identifier: MacBookPro14,2
Processor Name: Intel Core i5
Processor Speed: 3.1 GHz
Number of Processors: 1
Total Number of Cores: 2
L2 Cache (per Core): 256 KB
L3 Cache: 4 MB
Memory: 16 GB
Boot ROM Version: MBP142.0169.B00
SMC Version (system): 2.44f1

@jan-wassenberg
Copy link
Member

Thanks for reporting this. Looks like the High Sierra compiler is more strict.
Can you confirm that c++ --version reports LLVM 7.3.0?
We'll update the code to avoid the type mismatch.
In the mean time, you can try defining HAVE_BOOLEAN=1 and boolean=bool before #include "jpeglib.h".

@jan-wassenberg
Copy link
Member

Should be fixed by 200c784, please re-open if not :)

@malchata
Copy link
Author

malchata commented Feb 5, 2018

It works! Thank you so much @jan-wassenberg! You rule!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants