Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental Builds: getDependencies task always runs and generates warning #165

Closed
ygnessin opened this issue Dec 9, 2020 · 1 comment · Fixed by #169
Closed

Incremental Builds: getDependencies task always runs and generates warning #165

ygnessin opened this issue Dec 9, 2020 · 1 comment · Fixed by #169

Comments

@ygnessin
Copy link

ygnessin commented Dec 9, 2020

Describe the bug
While analyzing my build times in Android Studio, I noticed a build warning coming from the getDependencies task stating that the task declares no outputs and therefore cannot be run incrementally. I am on the latest version of the OSS Licenses Plugin: 0.10.2

The full output from Android Studio is below:

At 18:29, Dec 08, 2020, Android Studio detected the following issue(s) with Gradle plugin com.google.android.gms.oss-licenses-plugin

Always-Run Tasks
Task runs on every build because it declares no outputs.

Plugin: com.google.android.gms.oss-licenses-plugin
Task: getDependencies
Task type: com.google.android.gms.oss.licenses.plugin.DependencyTask
Issues for the same task were detected in 1 module(s), total execution time was 1.7s (100.0%), by module:
  Execution mode: FULL, time: 1.7s (100.0%), determines build duration: true, on critical path: true, issues: Always-Run Tasks

====Build information:====
Execution date: 12/8/20, 6:29 PM
Total build duration: 10.5s
Configuration time: 3.2s (30.4%)
Critical path tasks time: 1.7s (15.8%)
Critical path tasks size: 1
AGP versions: 4.1.1
====Platform information:====
AI-201.8743.12.41.6953283, JRE 1.8.0_242-release-1644-b3-6915495x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.15.7, screens 2560x1440; Retina

AS: 4.1.1; Kotlin plugin: 1.4.21-release-Studio4.1-1; Android Gradle Plugin: 4.1.1; Gradle: 6.7; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

To Reproduce
Steps to reproduce the behavior:

  1. Execute a warm build of a project in Android Studio with no code changes
  2. Observe that getDependencies runs even though nothing changes
  3. Open the Build Analyzer and observe that this is a Warning

Expected behavior

  1. getDependencies supports incremental builds and does not run if nothing in the project changed between builds
  2. There are no warnings in the Build Analyzer window

Screenshots
N/A

Desktop (please complete the following information):

  • Gradle version: 6.7
  • Android Studio version 4.1.1
  • Plugin name and version: oss-licenses-plugin:0.10.2

Additional context
Thank you for this great library and build tool!

@ygnessin ygnessin changed the title Incremental Build Support: getDependencies task always runs and generates build warning Incremental Builds: getDependencies task always runs and generates warning Dec 9, 2020
@caller9
Copy link
Collaborator

caller9 commented Apr 5, 2021

https://github.com/google/play-services-plugins/releases/tag/oss-licenses-plugin-v0.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants