-tagroot and -tagleaf in UI aren't including the tag name?

[NHDaly]

Please answer these questions before submitting your issue. Thanks!

What version of pprof are you using?

If you run pprof from GitHub, what's the Git revision?
Commit: 905365e

What operating system and processor architecture are you using?

MacOS M2

What did you do?

Running the following profile with -tagroot threadid is not showing the threadid: tag name in the UI:

pprof -tagroot threadid -http localhost:60004 profile.pb.gz

profile.pb.gz

What did you expect to see?

I expected to see frames with the names threadid:1 and threadid:2, similar to what I see in the screenshots from #649, which added this feature. For example, this one:

What did you see instead?

Instead, I just see frames with the values of the tags, i.e. 1 and 2:

And same for -tagleaf:

Was this changed on purpose at some point, or is this a bug? I think I very much preferred the view I expected.

[aalexand]

The tag name for these nodes is placed in the filename field when the profile with -tagroot or -tagleaf is generated. But I think the default granularity is -functions which discards the filename during the aggregation. Try passing -filefunctions flag.

[aalexand]

Closing for now, we can re-open if needed.

[NHDaly]

Thanks. Maybe we can figure it out with the right settings then, cool. 👍

pprof -filefunctions -tagroot threadid -http localhost:60004 profile.pb.gz

😅 That doesn't seem to be quite right either - this shows only the tag name, but not the tag value:

[NHDaly]

^ @aalexand: I just reread this thread, and I think this was not resolved. Could I ask you to reopen until we can figure out the right set of flags?