Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

ProcessManager.start's first argument should be List<String> not List<dynamic> #10

Closed
Hixie opened this issue May 11, 2017 · 4 comments
Closed

Comments

@Hixie
Copy link
Contributor

Hixie commented May 11, 2017

I'm implementing ProcessManager.start and I don't understand what type I could receive in the first argument's list other than String, nor what to do with any other types.

@tvolkert
Copy link
Contributor

It's intentional - see https://github.com/google/process.dart/blob/master/lib/src/record_replay/command_element.dart

We could probably document that better in the interface.

@Hixie
Copy link
Contributor Author

Hixie commented May 11, 2017

Ah, yeah, that should definitely be documented.

Should I be worrying about CommandElement in my mock for ProcessManager?

@tvolkert
Copy link
Contributor

Nope

@stuartmorgan
Copy link
Contributor

Closing, as this package now lives in flutter/packages. Please file an issue in the Flutter issue tracker if this is still an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants