Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPods and Swift? #11

Closed
kenlaws opened this issue Feb 2, 2018 · 7 comments
Closed

CocoaPods and Swift? #11

kenlaws opened this issue Feb 2, 2018 · 7 comments

Comments

@kenlaws
Copy link

kenlaws commented Feb 2, 2018

The instructions seem to explicitly exclude the idea of adding this via CocoaPods and using it with Swift. Is this the case? I gave it a shot and was told,

Could not build Objective-C module 'FBLPromises'

@shoumikhin
Copy link
Contributor

Thank you for filing the issue, Ken!

We've been wrangling with CocoaPods for a few days already, and still couldn't come up with a proper Spec for Swift that wouldn't also break Bazel and Swift PM.

We've filed an issue on CocoaPods and are looking forward for any suggestions from the community. It has more details about the issues we're facing. We'll definitely keep you posted on the progress.

Thanks.

@kenlaws
Copy link
Author

kenlaws commented Feb 4, 2018

Thank you for the reply.

Hmmm. So I'm not crazy. There actually is an issue. How refreshing!

@ehyche
Copy link

ehyche commented Feb 6, 2018

I am facing the same issue. My Podfile looks like:

platform :ios, '9.0'

target 'GooglePromises' do
  use_frameworks!

  # Pods for GooglePromises
  pod 'PromisesObjC', '~> 1.0'
end

and when I do a "pod install", then open the workspace, and build, then it builds OK. But once I include:

import FBLPromises

into one of my project Swift files, then I get the compilation error:

'DotSyntax/FBLPromise+DotSyntax.h': file not found

at line 17 in FBLPromise+DotSyntax+All.h

@ghost
Copy link

ghost commented Feb 9, 2018

Any updates on this ?

@bigbangbear
Copy link

whether platform support ios 8?

@shoumikhin
Copy link
Contributor

Hey guys, thanks a lot for your patience and sorry for the delay!

Hopefully, we've finally got CocoaPods support for Swift now. Please refer the docs and close the issue once you confirm everything works properly. Or reply here if you still experience issues.

Regarding iOS 8, the only dependency Promises has is GCD and some basic containers from Foundation, so I don't think there're any real limitations on what version of iOS we can potentially support. We specify 9.0 in podspec just because it seems old enough. Let us know if that's a concern for you and we can think about adjusting it to older versions.

Thanks.

@ghost
Copy link

ghost commented Feb 11, 2018

Hey everyone,
Was able to successfully install the 'PromisesSwift' pod into an all Swift project. Will go ahead and close this issue.

Thanks again for everyone's patience!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants