Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the equation of deterministic DDIM sampling in the Null-text Inversion paper #36

Open
wendy-xiaozong opened this issue Feb 11, 2023 · 3 comments

Comments

@wendy-xiaozong
Copy link

Hi,

Thanks for this wonderful work! I have a question about the equation of deterministic DDIM sampling in the Null-text Inversion paper.
image
Based on my understanding, deterministic DDIM sampling is to set the $\sigma_t=0$ for equation 12 in the DDIM paper. It should be the following equation:
$z_{t-1} = \sqrt{\alpha_{t-1}}\left(\frac{z_t - \sqrt{1-\alpha_t}\cdot\epsilon_\theta(z_t,\mathcal{C},t)}{\sqrt{\alpha_t}}\right) + \sqrt{1-\alpha_{t-1}}\cdot\epsilon_\theta(z_t, \mathcal{C}, t)$
If you rewrite this equation into the Null-text Inversion paper version, it should be:
$z_{t-1} = \sqrt{\frac{\alpha_{t-1}}{\alpha_t}}z_t + \sqrt{\alpha_{t-1}}\left(\sqrt{\frac{1}{\alpha_{t-1}} - 1}- \sqrt{\frac{1}{\alpha_t}-1} \right)\cdot\epsilon_\theta(z_t, \mathcal{C}, t)$
Which is different from it the Null-text Inversion paper.

It may be my understanding is wrong. I would very much appreciate it if you could point me in the right direction!

Thanks,

Jueqi

@junseokoh1
Copy link

I have the sam question. When I campare equation of deterministic DDIM sampling in the Null-text Inversion paper, it is different with DDIM & DiffuisonCLIP & Diffusion models beat GAN papers.

@jwh97nn
Copy link

jwh97nn commented May 19, 2023

same question here, thought it would be a typo

@YasminZhang
Copy link

It is a typo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants