Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pruning unused imports #218

Open
lucasdicioccio opened this issue Sep 3, 2018 · 0 comments
Open

Consider pruning unused imports #218

lucasdicioccio opened this issue Sep 3, 2018 · 0 comments

Comments

@lucasdicioccio
Copy link
Contributor

Hi all. First of all great job with proto-lens. I'm pondering whether some improvement is possible to prevent proto-lens from generating unused imports (from what I've seen, they are often due to option-plugins imports). I've not enough hindsight to understand if such a pruning step would be feasible and correct in general.

For the context, I recently built and published a minimal etcd-v3 gRPC client (cf. https://hackage.haskell.org/package/grpc-api-etcd ). One minor annoyance is the need to generate Haskell code for some un-used annotations (e.g., Google.Api.Http -- which has no incidence on proto-lens code at runtime). The alternatives are: modify the .proto or modify the generated .hs code, both of which will bring more problems down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant