Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from haskell-src-exts #323

Closed
judah opened this issue May 27, 2019 · 1 comment
Closed

Move away from haskell-src-exts #323

judah opened this issue May 27, 2019 · 1 comment

Comments

@judah
Copy link
Collaborator

judah commented May 27, 2019

We currently use haskell-src-exts ("hse") in proto-lens-protoc to implement Data.ProtoLens.Compiler.Combinators. However, hse is effectively deprecated:

https://www.reddit.com/r/haskell/comments/bswd7m/haskellcafe_haskellsrcexts_no_more_releases/

The recommended alternative seems to be directly using the GHC API. Luckily, the Combinators module largely abstracts away hse's ADT. So we should be able to change it without too much code churn outside of that module.

This might also be a good time to do #57 (split out Combinators into a separate library).

This change would also help reduce build times. hse is notoriously slow to compile due deriving a large number of classes.

@judah
Copy link
Collaborator Author

judah commented Sep 27, 2019

Done in #336.

@judah judah closed this as completed Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant