Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java keyword "public" not escaped during proto generation #736

Closed
wadriance opened this issue Sep 20, 2023 · 1 comment
Closed

Java keyword "public" not escaped during proto generation #736

wadriance opened this issue Sep 20, 2023 · 1 comment

Comments

@wadriance
Copy link

wadriance commented Sep 20, 2023

See #46 for the same issue with the keyword "interface".

My protobuf files are in packages that include the word "public" like so:

package example.example.public.proto;

When the java files are built from the protos by the Gradle plugin, the generated Java packages contain the word "public" without any escaping, which causes compilation errors since "public" is a keyword in Java.

I can submit the fix if you can point me to the right spot.

@ejona86
Copy link
Collaborator

ejona86 commented Mar 11, 2024

This is not a plugin issue. https://github.com/protocolbuffers/protobuf is for the actual generated code. That other issue you mentioned was not for the plugin; it was fixed by a change in the protobuf repo.

@ejona86 ejona86 closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants