Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a support for oneof #33

Closed
goj opened this issue Sep 25, 2014 · 4 comments
Closed

Add a support for oneof #33

goj opened this issue Sep 25, 2014 · 4 comments
Assignees
Labels
proto3 refactoring Non-user-facing changes

Comments

@goj
Copy link

goj commented Sep 25, 2014

https://developers.google.com/protocol-buffers/docs/proto#oneof

Generating enum and being able to switch on which field is set (like in Java proto library) would be especially useful.

@wienczny
Copy link

👍
Currently oneof seems to be somewhat supported. They are generated as regular fields by dart-protoc-plugin. Support for selecting and getting the current field would be nice. But I think this is an dart-protoc-plugin issue.

@mit-mit mit-mit added the proto3 label Mar 9, 2018
@mit-mit mit-mit added the refactoring Non-user-facing changes label Sep 17, 2018
@gamebox
Copy link

gamebox commented Nov 22, 2018

I don't think this would be terribly difficult to implement, and not having it really dampens the usefulness of the plugin for the use cases in which I typically want to use protobuf.

Unless this assigned internally, I wouldn't mind submitting a PR as I'm hoping to use this for a Flutter side-project.

@ghost ghost assigned ghost and szakarias and unassigned ghost Nov 22, 2018
@szakarias
Copy link
Member

PRs are always welcome, but I am also starting to look at this, so it should be supported soon.

@szakarias
Copy link
Member

Fixed by #166 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proto3 refactoring Non-user-facing changes
Projects
None yet
Development

No branches or pull requests

5 participants