proto3 hazzers always generated

[kutoman]

I'm not sure whether this is an issue or intended. In the generated dart code the has.. method is always generated for a corresponding message field regardless of being labeled as optional or not. Does it make sense to generate those methods for none-optional fields?

[osa1]

Yes. We have a TODO about this in the code:

protobuf.dart/protoc_plugin/lib/src/protobuf_field.dart

Lines 129 to 140 in ba29983

	// TODO(sigurdm): to provide the correct semantics for non-optional proto3
	// fields would need something like the following:
	// return baseType.isMessage ||
	// descriptor.proto3Optional ||
	// parent.fileGen.descriptor.syntax == "proto2";
	//
	// This change would break any accidental uses of the proto3 hazzers, and
	// would require some clean-up.
	//
	// We could consider keeping hazzers for proto3-oneof fields. There they
	// seem useful and not breaking proto3 semantics, and dart protobuf uses it
	// for example in package:protobuf/src/protobuf/mixins/well_known.dart.

this was added in 1319847 which implemented proto3 optional syntax.

[kutoman]

oh I see. I didn't check the generator's code