Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise the warnings levels on the ObjC builds #1599

Closed
thomasvl opened this issue May 25, 2016 · 1 comment
Closed

Raise the warnings levels on the ObjC builds #1599

thomasvl opened this issue May 25, 2016 · 1 comment
Assignees
@thomasvl
Labels
objective-c

Comments

@thomasvl
Copy link
Contributor

Some projects using pretty strict warning levels on their builds; raising the warning levels on the protobuf builds themselves should help ensure the code (and generated code) passes tighter checks.
@thomasvl thomasvl self-assigned this May 25, 2016
thomasvl added a commit to thomasvl/protobuf that referenced this issue May 25, 2016
@thomasvl
Add more warnings to for the ObjC runtime build
c8a440d 
Working on protocolbuffers#1599, specifically:
- Turn on more warnings that the Xcode UI calls out with individual controls.
- Manually add:
  -Wundef
  -Wswitch-enum
- Manually add and then diable in the unittests because of XCTest's headers:
  -Wreserved-id-macro
  -Wdocumentation-unknown-command
- Manually add -Wdirect-ivar-access, but disable it for the unittests and in
  the library code (via #pragmas to suppress it). This is done so proto users
  can enable the warning.
@thomasvl thomasvl mentioned this issue May 25, 2016
Merged
@thomasvl
Copy link
Contributor Author

#1617 is adding one more warning, and with that I think I'm calling this closed. We can look at adding other specific warnings as folks hit issues, but these seems to get most of what Xcode exposes and what I've seen a some other projects turning on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasvl thomasvl

Labels
objective-c
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasvl