Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/Cleanup ObjC NSError reporting #1618

Closed
thomasvl opened this issue May 27, 2016 · 1 comment
Closed

Improve/Cleanup ObjC NSError reporting #1618

thomasvl opened this issue May 27, 2016 · 1 comment
Assignees

Comments

@thomasvl
Copy link
Contributor

  • GPBExceptionMessageKey is left in the code, but isn't used, it can go.
  • parse*FromData:…/initWithData: methods currently only return two error codes, see if we can do better. Under the hood, the CodedInputStream will raise a few different errors based on what fails. We likely can standardize those so we can expose explicit NSError codes for things like:
    • Hitting the recursion limit
    • malformed data (bad tags)
    • truncated data (needed more bytes then are available)
@thomasvl
Copy link
Contributor Author

thomasvl commented Jun 1, 2016

#1620 removed GPBExceptionMessageKey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant