Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide message extension (proto2) querying facilities via the Python descriptor pool #2248

Closed
soltanmm-google opened this issue Oct 13, 2016 · 5 comments
Closed

Provide message extension (proto2) querying facilities via the Python descriptor pool #2248

soltanmm-google opened this issue Oct 13, 2016 · 5 comments
Labels
enhancement python

Comments

@soltanmm-google
Copy link

C++ provides the methods FindExtensionByNumber and FindAllExtensions. gRPC reflection needs these as part of its protocol.

This issue is here mostly so that I have something to reference from TODOs in code.
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 13, 2016

What language is this issue about?

@soltanmm-google soltanmm-google changed the title Provide message extension (proto2) querying facilities via the descriptor pool Provide message extension (proto2) querying facilities via the Python descriptor pool Oct 13, 2016
@soltanmm-google
Copy link
Author

Yow - I missed that rather important tidbit!

For Python.

soltanmm-google added a commit to soltanmm-google/grpc that referenced this issue Oct 13, 2016
@soltanmm-google
Partially implement gRPC Python server reflection
b9515f6 
Some features relating to proto2 extension querying are missing due to
missing upstream features required to support them (see
protocolbuffers/protobuf#2248).
@soltanmm-google soltanmm-google mentioned this issue Oct 13, 2016
Merged
soltanmm-google added a commit to soltanmm-google/grpc that referenced this issue Oct 13, 2016
@soltanmm-google
Partially implement gRPC Python server reflection
7ce2995 
Some features relating to proto2 extension querying are missing due to
missing upstream features required to support them (see
protocolbuffers/protobuf#2248).
soltanmm-google added a commit to soltanmm-google/grpc that referenced this issue Oct 14, 2016
@soltanmm-google
Partially implement gRPC Python server reflection
aa6e084 
Some features relating to proto2 extension querying are missing due to
missing upstream features required to support them (see
protocolbuffers/protobuf#2248).
soltanmm-google added a commit to soltanmm-google/grpc that referenced this issue Oct 14, 2016
@soltanmm-google
Partially implement gRPC Python server reflection
83687f0 
Some features relating to proto2 extension querying are missing due to
missing upstream features required to support them (see
protocolbuffers/protobuf#2248).
soltanmm-google added a commit to soltanmm-google/grpc that referenced this issue Oct 28, 2016
@soltanmm-google
Partially implement gRPC Python server reflection
aff6936 
Some features relating to proto2 extension querying are missing due to
missing upstream features required to support them (see
protocolbuffers/protobuf#2248).
@soltanmm-google
Copy link
Author

I see this is implemented on master but not on the v3.1.0 tag. When can we expect the relevant change to make it into a release?

@soltanmm-google
Copy link
Author

soltanmm-google commented Dec 16, 2016 •
edited
Loading

cc @hsaliak @markdroth @nathanielmanistaatgoogle w.r.t. blocked Python gRPC reflection

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Mar 7, 2017

v3.2.0 release was out for a while. Please reopen if the needed support is still missing.

@xfxyjwf xfxyjwf closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xfxyjwf @soltanmm-google