Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Json - option to always print enums as ints #2735

Closed
na-ka-na opened this issue Feb 19, 2017 · 3 comments
Closed

C++ Json - option to always print enums as ints #2735

na-ka-na opened this issue Feb 19, 2017 · 3 comments

Comments

@na-ka-na
Copy link
Contributor

We use a lot of enums. So we'd like an option to always print enums as ints. It will significantly reduce the size of our generated json. I already have changes to do so, will send out a PR.
na-ka-na added a commit to na-ka-na/protobuf that referenced this issue Feb 19, 2017
@na-ka-na
Add an option to always print enums as ints in Json API
172e0a6 
protocolbuffers#2735
@na-ka-na na-ka-na mentioned this issue Feb 19, 2017
Merged
@na-ka-na
Copy link
Contributor Author

Here's the PR: #2736

@na-ka-na
Copy link
Contributor Author

Thank you for merging! Do I need to update the documentation too?

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Feb 22, 2017

@na-ka-na No, there isn't a dedicated developer guide page for C++ JSON API at the moment.

@xfxyjwf xfxyjwf closed this as completed Feb 22, 2017
@martinxsliu martinxsliu mentioned this issue May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@na-ka-na @xfxyjwf