Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in GPBDictionary converting #3164

Closed
KinderLi opened this issue Jun 1, 2017 · 1 comment
Closed

A bug in GPBDictionary converting #3164

KinderLi opened this issue Jun 1, 2017 · 1 comment

Comments

@KinderLi
Copy link

KinderLi commented Jun 1, 2017

I defined map<int32, int64> in the source proto file, but when the server put a value larger than 4294967296(2^32) and transfer to the iOS client, the value is incorrect.
I found a bug from GPBDictionary.m in line 409:
valueToFill->valueInt64 = GPBCodedInputStreamReadInt32(&stream->state_);
I think it should be:
409 valueToFill->valueInt64 = GPBCodedInputStreamReadInt64(&stream->state_);

                                                                    ^O^
@thomasvl
Copy link
Contributor

thomasvl commented Jun 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants