Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnShutdownDelete shadowing issue #4887

Closed
chronoxor opened this issue Jul 10, 2018 · 1 comment
Closed

OnShutdownDelete shadowing issue #4887

chronoxor opened this issue Jul 10, 2018 · 1 comment

Comments

@chronoxor
Copy link
Contributor

GCC 8.1.0 with -Wall -Werror -Wshadow -pedantic options

/home/travis/build/chronoxor/CppSerialization/modules/protobuf/src/google/protobuf/stubs/common.h:209:33: error: declaration of ‘const void* p’ shadows a parameter [-Werror=shadow]
OnShutdownRun([](const void* p) { delete static_cast<const T*>(p); }, p);
^
/home/travis/build/chronoxor/CppSerialization/modules/protobuf/src/google/protobuf/stubs/common.h:208:24: note: shadowed declaration is here
T* OnShutdownDelete(T* p) {
~~~^

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jul 10, 2018

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants