Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define no_threadlocal on OpenBSD #2290

Merged
merged 1 commit into from Oct 26, 2016

Conversation

ramrunner
Copy link
Contributor

OpenBSD like IOS and the android NDK does not support thread local storage.
this defines it in platform macros.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ramrunner
Copy link
Contributor Author

signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 26, 2016

ok to test

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 26, 2016

Test failure of php should be unrelated.

@xfxyjwf xfxyjwf merged commit e9d9e56 into protocolbuffers:master Oct 26, 2016
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 26, 2016

Thanks for the patch!

@ramrunner
Copy link
Contributor Author

thanks for merging. all the best!

@ramrunner ramrunner deleted the OpenBSDsupport branch October 27, 2016 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants