Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include in message_lite.cc #2367

Conversation

jbrianceau
Copy link
Contributor

This changes fixes "use of undeclared identifier 'INT_MAX'"
compilation error.

This changes fixes "use of undeclared identifier 'INT_MAX'"
compilation error.
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@acozzette
Copy link
Member

Thanks, Julien. By the way, what was the build environment (i.e. compiler and platform) where you ran into this compiler error?

@acozzette acozzette merged commit 01d321c into protocolbuffers:master Nov 16, 2016
@jbrianceau
Copy link
Contributor Author

I saw the error in Chromium try bots : https://codereview.chromium.org/2495533002/

See try bots results of Patch Set 2, for instance the linux_chromium_rel_ng (compile stdio) :

FAILED: newlib_pnacl/obj/third_party/protobuf/protobuf_lite/message_lite.o 
/b/c/cipd/goma/gomacc ../../native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-clang++ -MMD -MF newlib_pnacl/obj/third_party/protobuf/protobuf_lite/message_lite.o.d -DNACL_TC_REV=f7d719122cd7c2fe3ebc52e7c0b011c583bf3e9c -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_SPELLCHECK=1 -DDCHECK_ALWAYS_ON=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DENABLE_WEBRTC=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNDEBUG -DNVALGRIND -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Inewlib_pnacl/gen -I../../third_party/protobuf/src -fno-strict-aliasing -fcolor-diagnostics -O2 -fno-ident -fdata-sections -ffunction-sections -g1 -fvisibility=hidden -Werror -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-unused-function -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../third_party/protobuf/src/google/protobuf/message_lite.cc -o newlib_pnacl/obj/third_party/protobuf/protobuf_lite/message_lite.o
../../third_party/protobuf/src/google/protobuf/message_lite.cc:247:14: error: use of undeclared identifier 'INT_MAX'
  if (size > INT_MAX) {
             ^
../../third_party/protobuf/src/google/protobuf/message_lite.cc:296:19: error: use of undeclared identifier 'INT_MAX'
  if (byte_size > INT_MAX) {
                  ^
2 errors generated.

@jbrianceau jbrianceau deleted the add-missing-include-in-message-lite-cc branch December 21, 2016 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants