Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Android-specific code from stubs/hash.h #2495

Merged
merged 1 commit into from Dec 14, 2016

Conversation

acozzette
Copy link
Member

This #ifdef in hash.h causes us to give up on finding a hash function on
Android, when there do seem to be hash functions available in practice.
I also had to tweak a macro in map.h that was disabling on Android an
allocator construct() method that we need.

This #ifdef in hash.h causes us to give up on finding a hash function on
Android, when there do seem to be hash functions available in practice.
I also had to tweak a macro in map.h that was disabling on Android an
allocator construct() method that we need.
@bazel-io
Copy link

Can one of the admins verify this patch?

@jbrianceau
Copy link
Contributor

+1

This should solve errors I got with an android trybot on Chromium :

[UNKNOWN] PrecacheFetcherTest.PrecacheResourceSelection:
[ RUN      ] PrecacheFetcherTest.PrecacheResourceSelection
[libprotobuf FATAL ../../third_party/protobuf/src/google/protobuf/stubs/hash.h:188] Should never be called.[ CRASHED      ]
[UNKNOWN] PrecacheFetcherTest.PrecacheResourceSelectionMissingBitset:
[ RUN      ] PrecacheFetcherTest.PrecacheResourceSelectionMissingBitset
[libprotobuf FATAL ../../third_party/protobuf/src/google/protobuf/stubs/hash.h:188] Should never be called.[ CRASHED      ]
[UNKNOWN] TranslateRankerTest.CalculateScore:
[ RUN      ] TranslateRankerTest.CalculateScore
[libprotobuf FATAL ../../third_party/protobuf/src/google/protobuf/stubs/hash.h:202] Should never be called.[ CRASHED      ]
[UNKNOWN] TranslateRankerTest.LoggingDisabled:
[ RUN      ] TranslateRankerTest.LoggingDisabled
[libprotobuf FATAL ../../third_party/protobuf/src/google/protobuf/stubs/hash.h:202] Should never be called.[ CRASHED      ]
[UNKNOWN] TranslateRankerTest.RecordAndFlushEvents:
[ RUN      ] TranslateRankerTest.RecordAndFlushEvents
[libprotobuf FATAL ../../third_party/protobuf/src/google/protobuf/stubs/hash.h:202] Should never be called.[ CRASHED      ]
[UNKNOWN] TranslateRankerTest.ShouldOfferTranslation:
[ RUN      ] TranslateRankerTest.ShouldOfferTranslation
[libprotobuf FATAL ../../third_party/protobuf/src/google/protobuf/stubs/hash.h:202] Should never be called.[ CRASHED      ]

@acozzette acozzette merged commit 83d681e into protocolbuffers:master Dec 14, 2016
@acozzette
Copy link
Member Author

@jbrianceau Ah yes, I do think this should fix your test failures. The original symptom I saw was that exact crash. Let me know if you still see any issues after you test with this fix.

@acozzette acozzette deleted the android-hash branch December 14, 2016 21:41
bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
Removed Android-specific code from stubs/hash.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants