Fix python compatibility test #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Ping @haberman . The failure test CONFIG=php5.6_mac is not related. |
haberman
reviewed
Feb 8, 2017
| printer_->Print("try:\n" | ||
| " $alias$ = $copy_from$.$alias$\n" | ||
| "except AttributeError:\n" | ||
| " $alias$ = $copy_from$.$module$\n", |
There was a problem hiding this comment.
Please add a comment about the scenario where this is required. New generated code importing old generated code?
…d version(2.6.1 or older) generated code.
|
LGTM. |
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Fix python compatibility test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix python compatibility test when a new generated code public imports an old version(2.6.1 or older) generated code.