New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch logging library from logrus to klog. #36
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm wdyt ? @tstromberg
@andriyDev lint is failing |
@medyagh Fixed! |
LGTM |
fixes #35.
Previously, the primary logging library was logrus. However, triage-party (one of our dependencies) used klog. Since this is more standard for kubernetes, this switches us to klog. Some minor behavior has changed, for example the few lines using
logrus.Debugf
have been replaced withklog.Infof
.Note: We still implicitly depend on logrus through
github.com/spf13/viper
. In my use case, no log messages were produced by logrus though. We likely could remove viper since its only purpose is allowing variables to be defaulted to environment variables (which is a very limited usage).