-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fire raises "preexec_fn is not supported on Windows platforms" when using setuptools in windows #236
Comments
Thanks for reporting the bug. |
Hey there!, So
And
Maybe adding Also checking documentation https://docs.python.org/3/library/signal.html#signal.signal: On Windows, signal() can only be called with SIGABRT, SIGFPE, SIGILL, SIGINT, SIGSEGV, SIGTERM, or SIGBREAK. A ValueError will be raised in any other case. Note that not all systems define the same set of signal names; an AttributeError will be raised if a signal name is not defined as SIG* module level constant. |
One way to handle preexec_fn in Windows is by doing:
But If software is not tested in Windows I'm aware there might be some other issues. |
I got someone to try a couple things on a Windows machine, but they weren't able to reproduce the error. What version of windows? What version of Python? (Edit: I see it's 3.7.5) And can you confirm that |
Turns out we don't need preexec_fn, even on non-Windows systems. The fix is in af9d848 and we'll do a minor release early next week. Summary of the issue, now that we understand it:
|
Thanks |
The release v0.3.1 is live now. |
Hello,
I'm using fire 0.3.0 and I had an issue running fire script in Window 10. Code is the following:
Inside auttools/ethrelay.py module I defined:
Inside setup.py:
Error:
Best regards,
Andrea
The text was updated successfully, but these errors were encountered: