Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy import IPython [Remove IPython as a required dependency: Part 1] #46

Closed
dbieber opened this issue Mar 29, 2017 · 1 comment
Closed
Assignees

Comments

@dbieber
Copy link
Member

dbieber commented Mar 29, 2017

IPython is only used in two places:

  • inspectutils.py: only uses a single function from IPython (IPython.core.oinspect.Inspector().info), so maybe we could just strip that one function out of IPython or write an equivalent function from scratch. I would want permission from the IPython folks before doing the former.
  • interact.py: uses IPython for the --interactive flag, but this should really be optional. You'll notice the unused _EmbedCode function in interact.py. (https://github.com/google/python-fire/blob/master/fire/interact.py#L89) The reason that's there is to eventually enable Fire to be used without IPython as a required dependency.

This task is to lazily import IPython in the two places it's used.


This is Part 1 of the plan to remove IPython as a required dependency.
The plan is outlined here.

@dbieber
Copy link
Member Author

dbieber commented Mar 31, 2017

Done w/ 3db47f8

@dbieber dbieber closed this as completed Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant