QSeparableConv1D and 2D #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lishanok could you check this PR and internal CL? thanks. cc @danielemoro |
|
happy holidays! courtesy ping @lishanok and @danielemoro |
|
PTAL @lishanok and @danielemoro |
danielemoro
requested changes
Jan 6, 2021
There was a problem hiding this comment.
I believe this pull request is important since it properly implements QSeparableConv2D as a class and quantized layer instead of a function that simply creates other layers. However, we need to make sure that all parts of the QSeparableConv2D can be quantized.
danielemoro
approved these changes
Feb 2, 2021
qkeras-robot
pushed a commit
that referenced
this pull request
Feb 2, 2021
-- 1847f67 by Vladimir Loncar <vloncar@users.noreply.github.com>: Separable CNN implementation -- bb717bc by Vladimir Loncar <vloncar@users.noreply.github.com>: Add support for SeparableConv in utils -- cc23ec4 by Vladimir Loncar <vloncar@users.noreply.github.com>: Test case for separable conv -- bb2e6c7 by Vladimir Loncar <vloncar@users.noreply.github.com>: Support SeparableConv in AutoQ -- 72e2bd0 by Vladimir Loncar <vloncar@users.noreply.github.com>: Update readme with new layers -- 5ab8ec0 by Vladimir Loncar <vloncar@users.noreply.github.com>: Add a note about quantizing depthwise activations COPYBARA_INTEGRATE_REVIEW=#50 from vloncar:sep_conv 5ab8ec0 PiperOrigin-RevId: 355256946 Change-Id: I106d43da286e519899425a83544ffa2e4afedb35
|
The test is actually not failed since we have it tested successfully from internal system. It was just due to travis-ci.org service failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
QSeparableConv1DandQSeparableConv2D. The existingQSeparableConv2D(which expands toQDepthwiseConv2Dand 1x1QConv2D) that is based on MobileNet is retained and renamedQMobileNetSeparableConv2D