Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Choose stable hash function #3

Closed
andychu opened this issue Nov 10, 2014 · 1 comment
Closed

Choose stable hash function #3

andychu opened this issue Nov 10, 2014 · 1 comment

Comments

@andychu
Copy link
Contributor

andychu commented Nov 10, 2014

Criteria for choosing, in order of importance:

  1. Should be stable, and well defined
  2. Should be available in all languages (e.g. JavaScript could be an issue), or easy to implement in all languages.
  3. Should be reasonably fast to simulate

Candidates:

  • md5 (since it's stable, and available)
  • murmur hash

Ruled out:

  • sha1: we are using this for the demo, but it seems to imply you need a cryptographic hash function, which we should avoid.
  • city hash: not stable/versioned

This probably deserves a doc... i.e. we should go through the rationale for the choice, possibly with some performance tests.

Note: the simulation can be profiled. Random number generation seems to be a bottleneck much more than hashing.

@andychu
Copy link
Contributor Author

andychu commented Oct 16, 2015

Decided on md5 -- used in Python/Java/C++.

@andychu andychu closed this as completed Oct 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant