Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary SONAME bump #299

Closed
stefanor opened this issue Feb 1, 2021 · 4 comments
Closed

Unnecessary SONAME bump #299

stefanor opened this issue Feb 1, 2021 · 4 comments

Comments

@stefanor
Copy link
Contributor

stefanor commented Feb 1, 2021 •
edited

The SONAME bump in d2f86ca was unnecessary, I think.

The symbol was in not one of the ones that we expose in the shared library. See libre2.symbols for the filtering.

We should be able to go back to SONAME=9, without any issues.
@stefanor stefanor mentioned this issue Feb 1, 2021
Closed
@junyer
Copy link
Contributor

junyer commented Feb 2, 2021

Thanks, great catch! CharClass is exposed within the Google codebase (for historical reasons) and I had neglected to think about whether it was exposed within the open source project before bumping SONAME. :(

@junyer
Copy link
Contributor

junyer commented Feb 2, 2021

Tagged 2021-02-02.

@foutrelis
Copy link

Please consider skipping 10 when you need to bump it again, to avoid any confusion with 2021-02-01.

@junyer
Copy link
Contributor

junyer commented Feb 3, 2021

I will endeavour to remember. Please yell at me if I forget. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@foutrelis @stefanor @junyer