Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xz, lzma compression don't work #61

Closed
mharvey-jt opened this issue Jun 10, 2021 · 6 comments
Closed

xz, lzma compression don't work #61

mharvey-jt opened this issue Jun 10, 2021 · 6 comments

Comments

@mharvey-jt
Copy link

for xz, lzma but not gzip compression types, the output rpms are apparently corrupt:

rpmsample | rpm2cpio | cpio -t
cpio: premature end of archive

tested with rpm2cpio from rhel7 and upstream 4.16.1.3

@jarondl
Copy link
Collaborator

jarondl commented Jun 25, 2021

@djgilcrease - as the contributor of xz and lzma to rpmpack (#19) do you want to take a stab at this?

@djgilcrease
Copy link
Contributor

Sure, will take a look at it today.

@djgilcrease
Copy link
Contributor

this appears to be an issue specific to rhel7 I tested this with Fedora34, centos 8, centos 7 and I am not seeing this issue.

@djgilcrease
Copy link
Contributor

I would guess that rhel7 only really supports gzip based on https://docs.fedoraproject.org/ro/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch-package-structure.html#id674921

According to the LSB standards, the RPMTAG_PAYLOADFORMAT must always be cpio. The RPMTAG_PAYLOADCOMPRESSOR must be gzip. The RPMTAG_PAYLOADFLAGS must always be 9.

@mharvey-jt
Copy link
Author

Ok, makes sense. Thanks for investigating, let's close this now.

@jarondl
Copy link
Collaborator

jarondl commented Jun 27, 2021

Thank you @mharvey-jt for reporting, and thank you so much @djgilcrease for finding the reason!

Without doubt, rpm is the gift that keeps on giving. I think we'll treat this closed bug as documentation, if anyone else complains we may need to put something in the readme as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants