Shouldn't this public function check for null?

[alas]

Shouldn't this public function check for null?

s2geometry/src/s2/s2lax_loop_shape.h

Line 76 in ad5ef6c

const S2Point& vertex(int i) const { return vertices_[i]; }

context:

s2geometry/src/s2/s2lax_loop_shape.h

Line 96 in ad5ef6c

std::unique_ptr<S2Point[]> vertices_;

[jmr]

I don't think so. Could you explain why you think it should check for null?

The (undocumented, but hopefully apparent) precondition is 0 <= i && i < num_vertices(). Do you have an example test case that would be affected by your proposed change?

[alas]

I only asked cause it looks like a public facing API, I'm used to checking those for erroneous/malicious user input.

[smcallis]

This is a pretty common pattern in C++, in general you don't want to pay the cost for bounds checking. We have the new iteration API that prevents this is in the common case anyways. If we did bounds check then we have the question of what we would return when it fails. We don't use exceptions so we'd have to return a std::optional or absl::StatusOr probably, which would be a breaking change.

[alas]

closing then, ty