Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can safehtml support custom attributes like one that HTMX requires? #11

Open
mikeschinkel opened this issue Apr 4, 2024 · 0 comments
Open

Comments

@mikeschinkel
Copy link

I started a personal web project and decided to use this package rather than the default html/template as it seems like a responsible thing to do, but I am running into an error that I cannot get around without forking the package:

html/template:my.template.html: cannot escape action {{.Url}}: actions 
must not occur in the "hx-get" attribute value context of a "li" element

From reading the code is seems that you have hardcoded all potential element-attribute combinations into elementSpecificAttrValSanitizationContext and globalAttrValSanitizationContext/elementContentSanitizationContext and thus the hx-get attribute is disallowed, right?

Is there any reason why it would be unsafe to add a method that allows adding attributes to be considered valid, assuming they are adding using string literals passed to the method that would add them?

If not, seems like a really easy enhancement I could add and create a PR for? Would that be something you would consider allowing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant