Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SantaGUI headline not centered and ugly #159

Closed
tburgin opened this issue Apr 4, 2017 · 3 comments
Closed

SantaGUI headline not centered and ugly #159

tburgin opened this issue Apr 4, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@tburgin
Copy link
Member

tburgin commented Apr 4, 2017

Looks like this takes place with the commit a2a660d. Dropping this commit fixes the issue.
Something doesn't like the use of modules I guess.

Eww.
screen shot 2017-04-04 at 3 39 08 pm

When clicking on the text it turns black?
screen shot 2017-04-04 at 3 39 03 pm

@tburgin tburgin added the bug label Apr 4, 2017
@tburgin tburgin added this to the 0.9.18 milestone Apr 4, 2017
@tburgin tburgin self-assigned this Apr 4, 2017
@tburgin
Copy link
Member Author

tburgin commented Apr 4, 2017

Re-adding a pch for just SantaGUI fixes the issue 😕

@russellhancox
Copy link
Collaborator

This is caused by this ifdef, which exists because NSAttributedString's initWithHTML:documentAttributes method is defined in an AppKit extension (NSAttributedStringUIFoundationAdditions in UIFoundation.framework) and SNTBlockMessage is common code - the ifdef worked because of the way PCH's worked vs modules.

I'm sure there's an easy way we can check that AppKit is available that still works for modules.

@russellhancox
Copy link
Collaborator

Fixed with #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants