Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please review/revise/import wiki pages from my fork #59

Closed
arubdesu opened this issue Aug 10, 2016 · 4 comments
Closed

Please review/revise/import wiki pages from my fork #59

arubdesu opened this issue Aug 10, 2016 · 4 comments
Assignees

Comments

@arubdesu
Copy link
Contributor

Please import https://github.com/arubdesu/santa/wiki as you see fit, probably by cloning down with your creds and replacing the files locally.

I have three points that I could use help clarifying, although I know I'm hand-wave-y other places as well:

  • Can the regex's be arrays that therefore evaluate sequentially, or does it have to be 'one superregex to rule them all'?
  • Also about regex's, I'm assuming the code comments are telling me the truth about prepending ^ to those that don't have it
  • I messed up the attempt at putting 'skip's in asl.conf, if you could please throw in your working example

I also renamed pages over there, and probably didn't set all of the links between page sections 100% correctly, but unless you made me a collaborator on the repo it seems I can't edit the wiki here.

@russellhancox
Copy link
Collaborator

Done. I made a few changes to match reality.

Can the regex's be arrays that therefore evaluate sequentially, or does it have to be 'one superregex to rule them all'?

No, it has to be one regex for performance reasons. Of course, you can use | and the like.

Also about regex's, I'm assuming the code comments are telling me the truth about prepending ^ to those that don't have it

The code comments are correct but all that means is that the regex anchors at the beginning of the string so it can't start matching part way through a path. This helps to avoid accidental matches and improves performance.

I also removed the notes about the regexes only applying to the root volume, as that isn't true; file changes on external volumes will be logged if they match the regex.

I messed up the attempt at putting 'skip's in asl.conf, if you could please throw in your working example

Done.

@arubdesu
Copy link
Contributor Author

Cool! Just one thing I finally figured out: without restarting, HUP'ing syslogd is necessary to have the new config picked up. Please add that note to the bottom of https://github.com/google/santa/wiki/Configuration#logging-configuration

sudo killall -HUP syslogd

@russellhancox
Copy link
Collaborator

Done

@arubdesu
Copy link
Contributor Author

Cool! I'll consider this closed until new features drop. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants